Incorrect Translation Status Displayed on AI Translate Page Due to Outdated Entity Retrieval

Open on Drupal.org →

Created on 18 October 2024, 2 months ago

Problem/Motivation

The translation status of the node is somethies not correct in translate page of a node.
Somethimes, i get the "translate using ai" even if the content is translated.
And somethimes i dont get it when i should be able to translate.

It seems the issue is located in /ai/modules/ai_translate/src/Form/AiTranslateForm.php : Line 110
https://git.drupalcode.org/project/ai/-/blob/1.0.x/modules/ai_translate/...

The $entity->hasTranslation($langcode) do not send the right value.

Steps to reproduce

Not sure what cause the issue.

Proposed resolution

Make sure that we get the last value of the entity by loading it by id :

    $entity = $this->entityTypeManager->getStorage($entity_type)->load($entity_id);

Would be better to find why the value is not correct at the first place.

🐛 Bug report

Status

Active

Version

1.0

Component

Other Submodules

Created by

🇧🇪Belgium arwillame

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!207Incorrect Translation Status Displayed on AI Translate Page Due to Outdated Entity Retrieval
Open
🇧🇪Belgium arwillame
updated 9 days ago

Comments & Activities

Issue created by @arwillame
Merge request !207Make sure we have the last and correct value of the entity → (Open) created by arwillame
Pipeline finished with Success
2 months ago
Total: 160s
#313929
Comment 2 months ago →
🇧🇪Belgium arwillame
Loading the entity is not working in every cases.
It seems it could be linked to the workflow module. Still investigating.z
Pipeline finished with Canceled
9 days ago
Total: 122s
#367677
Pipeline finished with Success
9 days ago
Total: 159s
#367678
Comment 9 days ago →
🇧🇪Belgium arwillame
The issue was in fact linked to the fact we are using revisions in our site.

Inspecting the logic of the content translation controller

I discover that there is a check of the revision to be sure to load the right entity in the right revision.

I added this check in my merge request and it solves my issue.
Comment 9 days ago →
🇬🇧United Kingdom MrDaleSmith
Looks good to me.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024