- Issue created by @jhuhta
- 🇫🇮Finland jhuhta
The MR fixes the issue for me. See if there's problems in the approach or code.
Included also two unrelated minor things:
1) The delete button copy ("delete: 'Delete Model'") got saved to the settings, which I removed.
2) The Edit button text was misleading: "Edit Model", when the user was already editing and was about to save it.Does it need an update hook?
- 🇬🇧United Kingdom MrDaleSmith
I think it needs an update hook to copy the old settings into the new ones and then delete them. The PHP Unit tests are all failing as well (https://git.drupalcode.org/issue/ai-3481112/-/pipelines/311512) which suggests that the tests themselves need updating to accommodate the changed settings name (I've not looked).
- First commit to issue fork.
- 🇩🇪Germany marcus_johansson
Update script added and unit tests fixed. Getting merged.
-
marcus_johansson →
committed 645d616e on 1.0.x authored by
jhuhta →
Issue #3481112: fix models config import problem
-
marcus_johansson →
committed 645d616e on 1.0.x authored by
jhuhta →
- 🇬🇧United Kingdom scott_euser
In case you still have the issue after the update, check your ai_models.settings.yml and if models is empty like this:
models: {}, you can just delete the file - 🇫🇮Finland anaconda777
#9 worked for me thanks. Had to also drush cex, delete ai_models.settings.yml and drush cim
Automatically closed - issue fixed for 2 weeks with no activity.