- Issue created by @pdureau
- First commit to issue fork.
- Merge request !245#3481051 - Used Drupal YAML dumper instead of Symfony. β (Merged) created by SmovS
- πΊπ¦Ukraine SmovS Lutsk
I set the Drupal YAML dumper instead of Symfony.
The Drupal Yaml:encode() sets the indentation to 2 by default as we had.
I am not sure about the "The level where you switch to inline YAML". parameter.
We used 10 for this parameter but Drupal Yaml:encode() sets PHP_INT_MAX.Please review the MR !245
- π«π·France just_like_good_vibes PARIS
hello, nice work.
The code now is usingDrupal\Component\Serialization\Yaml
instead ofSymfony\Component\Yaml\Yaml
,
but we did not really improved yet in terms of prettier compliance. This is because the former class is using the latter class internally.
Do we introduce something on top to tackle a better prettier compatibility ? There is no ready to use PHP code or library to do that.
We only need it when we write components in the legacy module. Maybe it is better to let this task to the prettier linter itself?
I suggest to merge this issue like that. - π«π·France pdureau Paris
Better prettier compliance would be a nice side effect. Now we use
Drupal\Component\Serialization\Yaml
, if we can improve prettier compliance with just a few tweaks, let's do it. If not, it is OK.But worse prettier compliance is not acceptable. If the change low the compliance, let's keep
Symfony\Component\Yaml\Yaml
-
pdureau β
committed 56e86dc6 on 2.0.x authored by
smovs β
Issue #3481051 by smovs, pdureau: Use Drupal YAML dumper instead of...
-
pdureau β
committed 56e86dc6 on 2.0.x authored by
smovs β
- π«π·France pdureau Paris
prettier compliance is the same, so it is mergeable in my opinion
Do we introduce something on top to tackle a better prettier compatibility ? There is no ready to use PHP code or library to do that.
We only need it when we write components in the legacy module. Maybe it is better to let this task to the prettier linter itself?Yes, let's do nothing more.
Automatically closed - issue fixed for 2 weeks with no activity.