- Issue created by @useernamee
- 🇸🇮Slovenia useernamee Ljubljana
All 3 subtickets need review:
- 📌 Add tests for Lupus Decoupled views support Active
- 📌 Add tests for lupus_decoupled_form Active
- 📌 Add tests for Lupus Decoupled Block Active - 🇦🇹Austria fago Vienna
Let's mark this is as META and only set the issues with acutal code for needs-review.
- Status changed to Needs review
2 months ago 9:52am 10 March 2025 - 🇸🇮Slovenia useernamee Ljubljana
One issue left to review: 📌 Add tests for lupus_decoupled_form Active
- 🇦🇹Austria fago Vienna
I think we are pretty much done here, but there is one issue which confused me: Test location. It seems we have some tests under the main module, while others are split in the moduels we are testing. Where should tests go? I think we shall decide on a rule and then make a child-task to make sure it's enforced. Thoughts on the right rule?
- 🇸🇮Slovenia useernamee Ljubljana
Generally I'd argue that tests for specific functionality that a module provides should live in that module. We have however broken that pattern at the beginning with the general test and later on with the views integration.
For general tests:
- https://git.drupalcode.org/project/lupus_decoupled/-/blob/1.x/tests/src/...
- https://git.drupalcode.org/project/lupus_decoupled/-/blob/1.x/tests/src/...
I think it is fine if they stay on the top level module, but the views tests should go into the lupus_decoupled_views submodule.