Fix issue with entity browser widget not updating target_id correctly when cardinality is 1

Created on 15 October 2024, 4 months ago

Problem/Motivation

There is an issue with the EntityReferenceBrowserWidget where the target_id is not being reset correctly when an entity is removed, and the modal does not open correctly when adding a new entity if the field's cardinality is set to 1.

Steps to reproduce

Create a field with EntityReferenceBrowserWidget and set its cardinality to 1.
Add an entity using the entity browser.
Remove the entity.
Try to add a new entity.

Expected Behavior:
The target_id should be reset when an entity is removed.
The modal should open correctly when adding a new entity.
Actual Behavior:
The target_id is not reset when an entity is removed.
The modal does not open correctly when adding a new entity.

Proposed resolution

Ensure that the target_id is reset when an entity is removed.
Update the #default_value of the target_id element to handle the case when no entities are present.
Ensure the modal opens correctly when adding a new entity.

🐛 Bug report

Status

Needs work

Version

2.10

Component

Field widget

Created by

🇺🇦Ukraine v.dovhaliuk

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @v.dovhaliuk
Comment 4 months ago →
🇺🇦Ukraine v.dovhaliuk
The patch has been provided.
Comment 4 months ago →
🇺🇦Ukraine v.dovhaliuk
Comment 4 months ago →
🇺🇦Ukraine v.dovhaliuk
The patch has been updated to fix the warning:
Warning: Undefined array key -1 in Drupal\entity_browser\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget->formElementEntities() (line 779 of /var/core/www/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php).
Comment 4 months ago →
🇺🇦Ukraine v.dovhaliuk

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024