Since we are requiring PHP 8.3 for the 3.x branch we can start using constructor property promotion for injected dependencies and clean up a lot of useless boilerplate code. Since we are touching these, let's also take the opportunity to apply best practices where possible:
readonly.Since this affects a large number of classes this change will be too large for a single MR. Let's do this in batches so it is easier to review and merge.
Before:
use Drupal\Core\Messenger\Messenger;
/**
* Builds the form to delete Event series type entities.
*/
class EventSeriesTypeDeleteForm extends EntityConfirmFormBase {
/**
* The messenger service.
*
* @var \Drupal\Core\Messenger\Messenger
*/
protected $messenger;
/**
* Construct a EventSeriesTypeDeleteForm.
*
* @param \Drupal\Core\Messenger\Messenger $messenger
* The messenger service.
*/
public function __construct(Messenger $messenger) {
$this->messenger = $messenger;
}
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container) {
return new static(
$container->get('messenger')
);
}
}
After:
use Drupal\Core\Messenger\MessengerInterface;
/**
* Builds the form to delete Event series type entities.
*/
class EventSeriesTypeDeleteForm extends EntityConfirmFormBase {
public function __construct(
protected readonly MessengerInterface $messenger,
) {
$this->messenger = $messenger;
}
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container) {
return new static(
$container->get('messenger')
);
}
}
Since this changes our constructor signatures this introduces a B/C break which may affect custom code that extends our classes. For this reason this can only be done in 3.x.
Active
3.0
Recurring Events (Main module)
I have done the suggested changes in the files of controller, I ready to do change other files too if these changes looks good to you.
So kindly review.