Argument #1 ($ip) must be of type string, null given

Open on Drupal.org →

Created on 11 October 2024, 6 months ago

Problem/Motivation

TypeError: Drupal\crowdsec\Client::verifyIp(): Argument #1 ($ip) must be of type string, null given, called in /var/www/html/web/modules/contrib/crowdsec/src/Middleware.php on line 87 in /var/www/html/web/modules/contrib/crowdsec/src/Client.php on line 159 #0 /var/www/html/web/modules/contrib/crowdsec/src/Middleware.php(87): Drupal\crowdsec\Client->verifyIp(NULL)

Steps to reproduce

https://app.travis-ci.com/github/Gizra/drupal-starter/jobs/627031832
Install the site from zero using an install profile with crowdsec installed

Proposed resolution

Make sure we do not act on non-web requests

Remaining tasks

Create the MR

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report

Status

Active

Version

1.1

Component

Code

Created by

🇭🇺Hungary aron novak Hungary, Budapest

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!3Argument #1 ($ip) must be of type string, null given
Closed
🇭🇺Hungary aron novak
updated 6 months ago

Comments & Activities

Issue created by @aron novak
Comment 6 months ago →
🇭🇺Hungary aron novak Hungary, Budapest
https://github.com/Gizra/drupal-starter/pull/733
Merge request !3Do not check CLI requests → (Closed) created by aron novak
Pipeline finished with Success
6 months ago
Total: 204s
#307228

Comment 6 months ago →

jurgenhaas → committed 0fc383c6 on 1.1.x

Issue #3480150 by aron novak, jurgenhaas: Argument #1 ($ip) must be of...

Comment 6 months ago →
🇩🇪Germany jurgenhaas Gottmadingen
Thanks @aron novak for reporting this. I've implemented a slightly different approach which should be even more save against all sorts of scenarios where we don't get any client IP.
Comment 6 months ago →
System Message
jurgenhaas → closed merge request !3
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024