Missing div closing tag breaks block config layout

Created on 10 October 2024, 6 months ago

Problem/Motivation

If attributes are enabled and configured with more than one attribute a missing closing div "moves" block save button and delete link in an area where css (.hidden-attribute-field { display: none !important;} is hiding it.

Steps to reproduce

On /admin/config/content/block-class/settings Enable attributes with checkbox and configure "Quantity of attributes per block" with a value greater 1. Than try to configure a block.

Proposed resolution

add missing closing div tag

Remaining tasks

add code change

User interface changes

-

API changes

-

Data model changes

-

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @c-logemann
  • Merge request !57Added missing closing div tag. β†’ (Open) created by c-logemann
  • Pipeline finished with Failed
    6 months ago
    Total: 152s
    #306525
  • πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany

    The code change is really simple. See MR.

  • πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany
  • πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany

    Because there is no difference between last 2.0.x and and current 4.0.x I just changed the target branch to 4.0.x in MR and for this issue.

  • Pipeline finished with Failed
    4 months ago
    #347089
  • Pipeline finished with Failed
    4 months ago
    Total: 224s
    #367078
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany

    I don't want to get this fix messed up. But just a note to improve translations. There is currently there is lot's of unneeded html inside the t():

    $help_text .= $this->t('<a href="@url_used_attribute_list@" class="use-ajax" data-dialog-options="{&quot;width&quot;:800}" data-dialog-type="modal">See all the attributes used</a>.', [
              '@url_used_attribute_list@' => $url_used_attribute_list,
            ]);
    

    It would be better to only put "See all the attributes used" inside t().

  • πŸ‡«πŸ‡·France zigazou

    Hi!

    The patch works as expected for the attribute fields group:

    But it does nothing for the class fields group:

    Note: translation of "Add another class" and "Remove last added class" could be included as well.

  • πŸ‡§πŸ‡·Brazil renatog Campinas

    Thanks for your feedback @zigazou

    translation of "Add another class" and "Remove last added class" could be included as well

    This one has been fixed at πŸ› Some button labels are not translatable Active

  • πŸ‡΅πŸ‡°Pakistan dewancodes

    @rentog, Yes, you are right here. I expect the same thing to be pointed out here for the multilingual sites.

  • Status changed to Needs work 6 days ago
  • πŸ‡ΊπŸ‡¬Uganda Thomas Kaisuka

    Thanks for this, In my case, it was hiding the save and delete button were being hidden. Which was bizzare,

    The patch fixed it in the new Drupal CMS V1

  • πŸ‡©πŸ‡ͺGermany c-logemann Frankfurt/M, Germany

    The status "Needs work" was argued to translations which are not focus of this issue and were fixed as reported at #8 and #9. So switching back to "Needs review".

    Thanks @thomas kaisuka for testing. I think the result is an argument for RTBC.

Production build 0.71.5 2024