- Issue created by @c-logemann
- π©πͺGermany c-logemann Frankfurt/M, Germany
The code change is really simple. See MR.
- π©πͺGermany c-logemann Frankfurt/M, Germany
Because there is no difference between last 2.0.x and and current 4.0.x I just changed the target branch to 4.0.x in MR and for this issue.
- Issue was unassigned.
- Status changed to Needs review
4 months ago 9:36pm 12 December 2024 - π©πͺGermany c-logemann Frankfurt/M, Germany
I don't want to get this fix messed up. But just a note to improve translations. There is currently there is lot's of unneeded html inside the t():
$help_text .= $this->t('<a href="@url_used_attribute_list@" class="use-ajax" data-dialog-options="{"width":800}" data-dialog-type="modal">See all the attributes used</a>.', [ '@url_used_attribute_list@' => $url_used_attribute_list, ]);
It would be better to only put "See all the attributes used" inside t().
- π«π·France zigazou
Hi!
The patch works as expected for the attribute fields group:
But it does nothing for the class fields group:
Note: translation of "Add another class" and "Remove last added class" could be included as well.
- π§π·Brazil renatog Campinas
Thanks for your feedback @zigazou
translation of "Add another class" and "Remove last added class" could be included as well
This one has been fixed at π Some button labels are not translatable Active
- π΅π°Pakistan dewancodes
@rentog, Yes, you are right here. I expect the same thing to be pointed out here for the multilingual sites.
- Status changed to Needs work
6 days ago 9:41am 28 March 2025 - πΊπ¬Uganda Thomas Kaisuka
Thanks for this, In my case, it was hiding the save and delete button were being hidden. Which was bizzare,
The patch fixed it in the new Drupal CMS V1
- π©πͺGermany c-logemann Frankfurt/M, Germany
The status "Needs work" was argued to translations which are not focus of this issue and were fixed as reported at #8 and #9. So switching back to "Needs review".
Thanks @thomas kaisuka for testing. I think the result is an argument for RTBC.