Contrib.social

Adjust league/commonmark depdency range

Open on Drupal.org →
Created on 10 October 2024, 7 months ago

Problem/Motivation

Currently the dependency defines "league/commonmark": "~2.4.0"
which seems quite conservative and might hinder other modules from being installed.
Currently I know of druapl/ai which will come with a "league/commonmark": "~2.5" dependency.

Steps to reproduce

Proposed resolution

Adjust dependency to "league/commonmark": "~2.4" which should cover the range >=2.4 <3.0.0

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Updated version range of dependency league/commonmark
📌 Task
Status

Needs work

Version

2.0

Component

Code

Created by

🇨🇭Switzerland das-peter

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @das-peter
  • Merge request !23Issue #3479849: Adjust league/commonmark depdency range → (Open) created by das-peter
  • Comment 7 months ago →
    🇨🇭Switzerland das-peter
  • Merge request !1Issue #3479849: Adjust league/commonmark depdency range → (Merged) created by das-peter
  • Comment 7 months ago →
    🇯🇴Jordan Rajab Natshah Jordan

    Thanks, Peter, for reporting and the MR.

    ~2.4 is the same as ~2.4.0
    Having the .0 at the end is telling the composer to only bring a stable version. ( no RC, Beta, or alpha versions) which was the intended of adding it.

    Next Significant Release Operators#

    Tilde Version Range (~)#

    The ~ operator is best explained by example: ~1.2 is equivalent to >=1.2 <2.0.0, while ~1.2.3 is equivalent to >=1.2.3 <1.3.0. As you can see it is mostly useful for projects respecting semantic versioning. A common usage would be to mark the minimum minor version you depend on, like ~1.2 (which allows anything up to, but not including, 2.0). Since in theory there should be no backwards compatibility breaks until 2.0, that works well. Another way of looking at it is that using ~ specifies a minimum version, but allows the last digit specified to go up.

    Example: ~1.2

    Note: Although 2.0-beta.1 is strictly before 2.0, a version constraint like ~1.2 would not install it. As said above ~1.2 only means the .2 can change but the 1. part is fixed.

    Note: The ~ operator has an exception on its behavior for the major release number. This means for example that ~1 is the same as ~1.0 as it will not allow the major number to increase trying to keep backwards compatibility.

    NOTICE: Update the composer from ~2.7 to ~2.8
    Composer 2.8.0 and 2.8.1 were released 5 days ago
    https://github.com/composer/composer/releases/tag/2.8.0
    Many additions/Improvements/Fixes in the Changelog
    Followed up with 2.8.1
    https://github.com/composer/composer/releases/tag/2.8.1

    • Fixed init command regression when no license is provided (#12145)
    • Fixed --strict-ambiguous flag handling whereas it sometimes did not report all issues (#12148)
    • Fixed create-project to inherit the target folder's permissions for installed project files (#12146)
    • Fixed a few cases where the prompt for using a parent dir's composer.json fails to work correctly (#8023)

    Drupal Core 10.4 and 11 will require that by default

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024