- Issue created by @useernamee
- ๐ฎ๐ณIndia mohd sahzad
mohd sahzad โ made their first commit to this issueโs fork.
- ๐ธ๐ฎSlovenia useernamee Ljubljana
Thank you for PR @mohd sahzad!
Could you also fix the phpcs issue? It makes sense to fix it here - and have a green pipeline from the beginning.
FILE: ...nitization-3479712/src/EventSubscriber/ExtensionSanitizationSubscriber.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Core\File\Event\FileUploadSanitizeNameEvent. | | (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses) --------------------------------------------------------------------------------
-
useernamee โ
committed 791c230f on main authored by
mohd sahzad โ
Issue #3479712 by mohd sahzad, arunsahijpal, useernamee: Add gitlab-ci...
-
useernamee โ
committed 791c230f on main authored by
mohd sahzad โ
-
useernamee โ
committed 791c230f on 1.0.x authored by
mohd sahzad โ
Issue #3479712 by mohd sahzad, arunsahijpal, useernamee: Add gitlab-ci...
-
useernamee โ
committed 791c230f on 1.0.x authored by
mohd sahzad โ
- ๐ธ๐ฎSlovenia useernamee Ljubljana
cspell is failing: https://git.drupalcode.org/project/extension_sanitization/-/jobs/3068906
imageapi should be added to the list of ignored words. - ๐ฎ๐ณIndia arunsahijpal
Hi @useernamee,
The readme.md does'nt exist in my branch, its in 1.0.x how can I fix it? - ๐ธ๐ฎSlovenia useernamee Ljubljana
You could merge 1.0.x into your branch.
- ๐ฎ๐ณIndia arunsahijpal
I have fixed the cspell error but it is showing some merge conflicts should i resolve them?
- ๐ฎ๐ณIndia arunsahijpal
Hi @useernamee,
I've resolved the merge conflicts, Kindly check it. - Status changed to RTBC
5 months ago 5:21am 9 December 2024 - ๐ฎ๐ณIndia chhavi.sharma
I reviewed the MR.
The cspell error is resolved and the pipeline is green.
Also, the merge conflict has been resolved.
So moving it to RTBC. - ๐ธ๐ฎSlovenia useernamee Ljubljana
Hello, thank you for contributing!
pipeline is now green, but I'd prefer it fixed in a cleaner way. see PR comment. - ๐ฎ๐ณIndia arunsahijpal
@useernamee ,
I've ignored the word through .gitlab-ci.yml, please check. -
useernamee โ
committed f13da47a on 1.0.x authored by
arunsahijpal โ
Issue #3479712 by arunsahijpal, mohd sahzad, useernamee, chhavi.sharma:...
-
useernamee โ
committed f13da47a on 1.0.x authored by
arunsahijpal โ
Automatically closed - issue fixed for 2 weeks with no activity.