Make Gitlab pipeline fully pass

Working on it

rest_menu_items has a new allowed_menus config option, that is very likely the cause of it failing. The test needs to allow the appropriate menu first.

PHPCS (Coding standards) issues solved in 17 files.
PHPCS pipeline is now passing
All other pipelines now pass except for PHPUnit which gives the following error:

Uploading artifacts as "archive" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
WARNING: /builds/issue/lupus_decoupled-3479682/web/sites/default/files/simpletest/phpunit-*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/issue/lupus_decoupled-3479682) 
Uploading artifacts as "junit" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables
ERROR: Job failed: command terminated with exit code 2

It says the phpunit-*.xml file is not found in the web folder (project root directory) and i dont have access to the root directory.

There's an issue with eslint. This change is required (from pipeline artifacts)

diff --git a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
index 78c8013..59a7619 100644
--- a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
+++ b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
@@ -38,7 +38,8 @@
         const $url = drupalSettings.responsive_preview.url;
         const $frontendBaseUrl = drupalSettings.lupus_decoupled_frontend_url;
         if ($frontendBaseUrl && $url.indexOf('://') < 0) {
-          $frame.get(0).contentWindow.location = `${$frontendBaseUrl} / ${$url}`;
+          $frame.get(0).contentWindow.location =
+            `${$frontendBaseUrl} / ${$url}`;
         } else {
           $frame.get(0).contentWindow.location = $url;
         }

The pipeline is green. I'm not sure why, but LupusSessionDomainFunctionalTest was complaining about menu_link_content somehow.

This fix has to be moved to 📌 Add tests for lupus_decoupled_form Active as well.

Thank you. Reviewed, looks good, so merged.

Automatically closed - issue fixed for 2 weeks with no activity.