Make Gitlab pipeline fully pass

Created on 9 October 2024, 15 days ago

Problem/Motivation

The "Composer (next major)" job just passed for the first time, thanks to rest_menu_items having a D11 compatible release.

But now, two tests are throwing a PluginNotFoundException: The "menu_link_content" entity type does not exist.

Also: all phpcs errors are quite recent, introduced by Gitlab's update to coder 8.3.25. Before, they were green. So we better just satisfy coder and make them green again -- so we're able to see new phpcs issues from the Job status.

Steps to reproduce

Check Gitlab job "phpunit (next version)" output. and phpcs.

Note rest_menu_item's own tests are also currently failing. But I'm not sure that is related to the apparent missing menu item (config entity).

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @roderik
  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
  • First commit to issue fork.
  • 🇮🇳India akulsaxena

    Working on it

  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    rest_menu_items has a new allowed_menus config option, that is very likely the cause of it failing. The test needs to allow the appropriate menu first.

  • Pipeline finished with Failed
    10 days ago
    Total: 450s
    #308911
  • 🇮🇳India akulsaxena

    PHPCS (Coding standards) issues solved in 17 files.
    PHPCS pipeline is now passing
    All other pipelines now pass except for PHPUnit which gives the following error:

    Uploading artifacts as "archive" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
    Uploading artifacts...
    junit.xml: found 1 matching artifact files and directories 
    WARNING: /builds/issue/lupus_decoupled-3479682/web/sites/default/files/simpletest/phpunit-*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/issue/lupus_decoupled-3479682) 
    Uploading artifacts as "junit" to coordinator... 201 Created  id=3042729 responseStatus=201 Created token=glcbt-64
    Cleaning up project directory and file based variables
    ERROR: Job failed: command terminated with exit code 2

    It says the phpunit-*.xml file is not found in the web folder (project root directory) and i dont have access to the root directory.

  • 🇸🇮Slovenia useernamee Ljubljana

    There's an issue with eslint. This change is required (from pipeline artifacts)

    diff --git a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
    index 78c8013..59a7619 100644
    --- a/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
    +++ b/modules/lupus_decoupled_responsive_preview/js/lupus_decoupled_responsive_preview.js
    @@ -38,7 +38,8 @@
             const $url = drupalSettings.responsive_preview.url;
             const $frontendBaseUrl = drupalSettings.lupus_decoupled_frontend_url;
             if ($frontendBaseUrl && $url.indexOf('://') < 0) {
    -          $frame.get(0).contentWindow.location = `${$frontendBaseUrl} / ${$url}`;
    +          $frame.get(0).contentWindow.location =
    +            `${$frontendBaseUrl} / ${$url}`;
             } else {
               $frame.get(0).contentWindow.location = $url;
             }
    
  • 🇸🇮Slovenia useernamee Ljubljana

    The pipeline is green. I'm not sure why, but LupusSessionDomainFunctionalTest was complaining about menu_link_content somehow.

    This fix has to be moved to 📌 Add tests for lupus_decoupled_form Active as well.

  • Pipeline finished with Skipped
    6 days ago
    #314083
  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Thank you. Reviewed, looks good, so merged.

Production build 0.71.5 2024