- Issue created by @a.dmitriiev
- Merge request !49Issue #3479607: Support config actions for using config split with Drupal recipes → (Open) created by a.dmitriiev
- 🇨🇭Switzerland bircher 🇨🇿
Thanks for the issue and thanks for the patch! i was thinking about adding some config actions during Drupalcon Barcelona, but then I didn't really know what would be useful and I am not sure just adding things for the sake of adding things is the right thing to do.
I think we shouldn't add actions for themes until ✨ Multisite setup ignore theme Needs work in other words until themes actually can be split.
Then I have some reservations for the names of adding and removing from the lists, in particular how that works with plurals, for modules addModule becomes addModules but addToCompleteList would become addToCompleteLists and that seems awkward, but I don't know what would be better.
And finally for addModule, I don't know if setting the module weight to 0 is a good enough solution or if we should allow setting the weight or if we should check the installed modules and set a weight based on that if it is available.
And lastly of course it would be great to have a test that runs these actions by means of applying a test recipe.
- 🇩🇪Germany a.dmitriiev
It is possible to control the plural form of the method name that will be a config action with
pluralize
attribute.I think for
addToCompleteList
the plural one should beaddToCompleteListMultiple
? That would be the most obvious, what do you think?As for the themes, if it is not ready yet, let's remove it for now, of course.
Regarding the module weight, you are right, let's allow to set the weight as well.
- 🇩🇪Germany a.dmitriiev
I have removed
theme
methods, added plural forms foraddToCompleteList
,removeFromCompleteList
,addToPartialList
and toremoveFromPartialList
. Also it is now possible to pass the module weight inaddModule
method.Regarding the tests, I heard that recipe initiative is working on some test template, I will try to check, but I am not sure what kind of test it will be.