- Issue created by @sokru
- 🇮🇳India mohd sahzad
mohd sahzad → made their first commit to this issue’s fork.
- 🇫🇮Finland sokru
I tried to keep the changes as minimal as possible, Eslint, Stylelint and CSPell issues should be handled on separate issue.
- 🇦🇺Australia darvanen Sydney, Australia
Have made a few comments on the MR, of particular concern is the removal of some of the logical structures.
The most common procedure I have seen on other modules has been to just have this issue turn on CI then create follow-ups for all of the issues arising from the tests. I suggest we do that here too.
- Status changed to Needs work
20 days ago 6:40am 3 February 2025 - First commit to issue fork.
- 🇮🇳India rajeshreeputra Pune
To ensure clarity and simplicity, let's add the
.gitlab-ci.ymlfile as part of this issue. Will address and resolve the issue reported by the CI in the associated tickets.- Spell check warnings - 📌 Fix spell check issue reported by CI. Active
- PHPCS warnings - 📌 Fix PHPCS warnings reported by CI. Active
- PHPStan warnings - 📌 Fix PHPStan warnings reported by CI. Active
- StyleLint warnings - 📌 Fix StyleLint warnings reported by CI. Active
- StyleLint warnings - 📌 Fix ESLint warnings reported by CI. Active
Hence moving ahead and requesting review.