Integrate SDDS base theme tag component with XB

Created on 7 October 2024, 3 months ago

Problem/Motivation

Test+tweak base theme tag component to work with XB.

Steps to reproduce

Proposed resolution

Test+tweak base theme tag component to work with XB.

Remaining tasks

See above.

User interface changes

Component will work with XB.

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Kristen Pol
  • I couldn't find any problems when I tested, but maybe there is missing functionality. It just works like a button that links off to something.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    It would be good to do a side-by-side comparison with Storybook to see if it matches: https://uikit.civictheme.io/

  • Here's the comparison with tab on storybook, looks pretty good

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Awesome. Would be great to:

    1. Add the icons so they are in a list (see other examples)
    2. Make sure the component defaults looks are the same as storybook (except for colors)

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Actually, looks like you compared against storybook already so just the icons are left.

  • Pipeline finished with Success
    2 months ago
    Total: 166s
    #313094
  • I added the icons but these ones aren't working:
    - document
    - layer
    - layers
    - lock-file
    - lock-gallery
    - mobile
    - open-source
    - users
    - water-drop
    - web

  • Pipeline finished with Success
    2 months ago
    #313104
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Where are those from?

    These are the ones I see in the theme:

    kristens-mbp-2:assets kristenpol$ ls icons/
    account.svg		close-outline.svg	exclamation-mark-3.svg	linkedin.svg		right-arrow-1.svg	upper-arrow.svg
    approve.svg		close.svg		eye.svg			magnifier.svg		right-arrow-2.svg	upper-right-arrow.svg
    bars.svg		down-arrow-1.svg	facebook.svg		map.svg			select-box.svg		watch.svg
    bullet.svg		down-arrow-2.svg	help.svg		megaphone.svg		share.svg		word-file.svg
    calendar-1.svg		down-arrow-large.svg	image.svg		message.svg		square.svg		x.svg
    calendar-2.svg		download-file.svg	information-mark.svg	mortarboard.svg		to-do.svg		youtube.svg
    call.svg		download.svg		instagram.svg		newspaper.svg		twitter.svg
    cancel.svg		exclamation-mark-1.svg	left-arrow-outline.svg	pdf-file.svg		up-arrow-large.svg
    checked.svg		exclamation-mark-2.svg	left-arrow.svg		progress.svg		up-arrow.svg
    
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Ah... maybe you found in here?

    components/00-base/about-civictheme/about-civictheme.stories.twig

    Looks like there are icons listed in that twig file that aren't in the icons folder.

    Please create an issue here:

    https://www.drupal.org/project/issues/civictheme β†’

  • Pipeline finished with Success
    2 months ago
    Total: 166s
    #316515
  • Pipeline finished with Success
    about 2 months ago
    Total: 255s
    #318758
  • Pipeline finished with Success
    about 2 months ago
    Total: 163s
    #319904
Production build 0.71.5 2024