Integrate SDDS base theme image component with XB

Created on 7 October 2024, 3 months ago

Problem/Motivation

Test+tweak base theme image component to work with XB.

Steps to reproduce

Proposed resolution

Test+tweak base theme image component to work with XB.

Remaining tasks

See above.

User interface changes

Component will work with XB.

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Kristen Pol
  • Do we want to just go with the twig & yml we created in starshot-image?

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Ideally, we'd have these props:

    • image
    • width
    • height
    • modifier_class

    Give it a try, but note that it may not work yet due to:

    πŸ› Redux support for ImageWidget: `[image] String value found, but an object is required` Postponed

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Actually, I think it should work because this works:

    starshot_demo/components/03-organisms/starshot-hero/starshot-hero.component.yml

    which has a title and image prop.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Created an issue to test that the test component:

    πŸ“Œ Test SDDS campaign2 for image+title error Active

  • Pipeline finished with Success
    2 months ago
    Total: 195s
    #306653
  • Pipeline finished with Success
    2 months ago
    Total: 166s
    #306684
  • Current problems with my iterations of the image component:
    - The uploaded image disappears when the size is changed. Even when the height is changed, even though height doesn't work right now.
    - The height prop doesn't do anything. It seems like it's programmed right in the twig, unless I'm missing something. So I'm not sure where the problem lies for this bug.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    I've noticed the image revert bug before and never reported it.

    It would be great if you would create an issue for XB (for the image revert bug) with detailed instructions how to reproduce and include a video for it and add a link here to that issue.

  • Pipeline finished with Success
    2 months ago
    Total: 238s
    #312012
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    @alan.cole We want to have a default for some example images like for the image component... should it be in a assets/images directory or ?

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks. Back to Jacob. Put the image in components/assets/images and adjust the path in the base theme and the subtheme.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    For real.

  • The original starshot_placeholder_image_1.jpg is contained in these extra files:

    ./starshot_demo/storybook-static/static/media/starshot_placeholder_image_1.1fc788ef.jpg
    ./starshot_demo/storybook-static/main.f3f1a652.iframe.bundle.js
    ./starshot_demo/components_combined/03-organisms/starshot-hero/starshot-hero.component.yml
    ./starshot_demo/components_combined/03-organisms/starshot-case-study/starshot-case-study.component.yml
    ./starshot_demo/components_combined/01-atoms/starshot-image/starshot-image.component.yml
    ./starshot_demo/dist/scripts.js
    ./starshot_demo/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/9e/3c/ec8b035cacf7950ede8ef72451e8e29d5f615d24af184a87c4dcf9a49c084c69d2c617c96c5a7c28cfcc445e6c8f9a701d85a9638c889964f1f4370e523f
    ./starshot_demo/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/05/7d/9aa4f37541d9a16a4738deb1e3e84e8eb3e58918981243b6ebdde3ee251eb767147ef392bb1e0963da7fc9abd87dd7b4aee133a367cc863a5e353721eae8
    ./starshot_demo/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/be/a3/1ee6ce7f047afdd9da3167e7f13601be36a7c2b1fb90beece4c172ee2a99367733b3732737e3c63d5d166909c597c25b8433cf0971418706afb95828bbc3
    ./starshot_demo/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/2f/ac/2fb6165446aa1684294bd0e86b92909af4544fceebf26555465e1885816cff1e974416e0ab8015699cf2757ffca300907f60ef9b9e814269c4882efba91a
    ./starshot_demo/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/f1/48/127d5471b21e393cf084c574a287ef8969dcb237b3514a14e9d37a03ea141b96defe8aba81011457293e118c76aeb032f770037850e304efdd3332b074ff
    ./.git/index
    
  • Pipeline finished with Success
    2 months ago
    Total: 166s
    #314140
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks. Code looks good.

    I'll do a quick test before merging but otherwise marking RTBC for now.

Production build 0.71.5 2024