Contrib.social

Inconsistent listing results after module reinstallation

Open on Drupal.org →
Created on 7 October 2024, 7 months ago

Problem/Motivation

After reinstalling the module existing media items once created with DAM-related media types still appear on Drupal core's media listing page but they all disappear from the module's own “DAM assets” listing page. Administrators may find this discrepancy disturbing as it confuses them about whether these media items still exist or have been gone.

Steps to reproduce

  1. Install the module, authenticate the site-wide client and your user account too with Widen.
  2. Create any media items through DAM. Ensure that in the media__acquia_dam_asset_id table, a record representing it exists.
  3. Visit the /admin/content/media page. Ensure that the media item is listed.
  4. Visit the /admin/content/dam-media page. Ensure that the media item is listed here too.
  5. Uninstall the module either via the GUI or by the Drush command. Ensure that the media__acquia_dam_asset_id table gets dropped in the DB.
  6. Install the module again by any means mentioned above. Ensure that the media__acquia_dam_asset_id table got created fully empty.
  7. Authenticate the site-wide client and your user account too with Widen.
  8. Visit the /admin/content/media page. Ensure that the media item is still listed.
  9. Visit the /admin/content/dam-media page.
    • Expected: the media item should be listed because Core's media table still holds a record of it.
    • Actual: the list is empty.

This is because the current filtering logic implemented as a Views filter (source code) strictly checks the existence of records within the media__acquia_dam_asset_id table. However, when the module uninstalls, this table – among others – gets dropped, but the media items created remain. Next time, when the module is installed again the still existing media items have no mention in the examined DB table, therefore the Views listing returns empty results.

Proposed resolutions

  1. Add exclusion of the media__acquia_dam_asset_id table on module uninstallation. Arguments:
    • Pro: probably the easiest solution
    • Contra: residue remains in the DB which is against the general best-practice of the Drupal ecosystem.
  2. Alter the module process to let the administrator decide when uninstalling the module whether they want to preserve this table or not. Explain them the reasoning why is it asked. If opted to preserve, then see option #1. Suggest a default option for this decision (probably to not preserve).
    • Pro: best of both worlds, responsibility given to human instead of false but hardcoded assumptions.
    • Contra: research needed on how easy to alter the module uninstallation process.
  3. Change the filtering logic to check different values to tell whether a DAM-related media item still exists or not.
    • Pro: no user interface change, only the information content gets improved.
    • Contra: needs to figure out what other values we can check.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.0

Component

User interface

Created by

🇭🇺Hungary Balu Ertl Budapest 🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024