Contrib.social

Don't store the stage ID in the project_browser tempstore

Open on Drupal.org →
Created on 6 October 2024, 4 months ago

Problem/Motivation

Right now, InstallerController has messy, tortured logic around its setRequiringState() method, which is very hard to untangle, but we'll need to do it to implement the new "install multiple projects in one go" UX in a refresh-tolerant way.

One thing we could do to improve the situation right now is to stop storing the installer's stage ID in the tempstore. We really don't need to; the frontend knows what it is and could pass it to the apply and post-apply routes. So let's do that:

  • The apply and post-apply routes should require the stage ID as a URL parameter. For example: /admin/modules/browser/install-apply/STAGE_ID.
  • The controller should no longer store the stage ID in the tempstore, and indeed, the $stage_id parameter of setRequiringState() should be removed.
✨ Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024