- Issue created by @traviscarden
- Merge request !351Issue #3478830 by traviscarden: Remove dead `ApiResponseValidator::performXbValidation()` β (Merged) created by traviscarden
- πΊπΈUnited States traviscarden
Since π Openapi.yml uses patternProperties which is not supported by our dependencies Needs work is yours, @tedbow, I'll ask you to approve this.
- πΊπΈUnited States tedbow Ithaca, NY, USA
yep, this find we can add it back exactly in the other issue if we need it
-
traviscarden β
committed bcf659ba on 0.x
Issue #3478830 by traviscarden: Remove dead `ApiResponseValidator::...
-
traviscarden β
committed bcf659ba on 0.x
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
The removal of
x-xb-validation
in/openapi.yml
seems to have been accidental in this commit: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... ? π€ - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Yes β¦ it's me asking for confirmation whether this piece of code was intentionally dead or just accidentally wounded π
- πΊπΈUnited States traviscarden
"Wounded." Haha. No, it was actually dead. As I understand @tedbow per a conversation we had outside this issue, it was removed on purpose and put back in by accident during a merge or rebase. Trust us, @wim leers : we don't make mistakes around here. At least not when we're correcting our mistakes. π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π
What a lovely comment! π
Automatically closed - issue fixed for 2 weeks with no activity.