- Issue created by @scott_earnest
- 🇺🇸United States scott_earnest
Yes sorry - this was off the patch I created. I did not realize that this introduced a deprecation with a drush warning when clearing the cache.
I determined that a site's settings.php file get's loaded twice? Not sure why this was but because of this all settings get loaded twice.
I was not sure the best way to extract the "convert" piece in an .inc file - but this obviously causes problems with including it twice.
I though a path forward would be to check for "function exists", and also rename specific to the module.
- Merge request !4Issue #3477448 by scott_earnest: Better convert function → (Open) created by scott_earnest
- 🇺🇸United States effulgentsia
I think instead we can use an anonymous function assigned to a local variable:
$convert = function(...) {...}. - 🇺🇸United States scott_earnest
@effulgentsia - thanks for that suggestion! That's cool. I updated the MR with the anonymous function method.
Leaving in "Needs review" for now if someone else wants to test. If so make sure to follow the setup from the parent issue please and thank you:
https://www.drupal.org/project/mysql57/issues/3477448 🐛 Error when target is an array of connections Active