- Issue created by @dxvargas
- Merge request !123Issue #3477873: Fix return type for PrivateMessageConfigFormBase::validateForm() β (Merged) created by dxvargas
- ππΊHungary huzooka Hungary ππΊπͺπΊ
The return type is obviously wrong, but I would just remove the type hints now to not break compatibility with e.g. Private Message Flood Protection β .
Anyway, since there is some overlap in the maintainers of this module and
private_message_flood
, I'd let maintainers to decide. - π΅πΉPortugal dxvargas
I can understand your preference @huzooka.
Not sure you've seen the related issue in #3477426 π Missing Return Type for PrivateMessageFloodPrivateMessageConfigForm::validateForm() Active in Private Message Flood Protection. I still think we should move here and quickly adapt there.But sure, let's wait for more feedback.
- ππΊHungary huzooka Hungary ππΊπͺπΊ
Re @dxvargas, Yes, I did, and it WFM, I just forgot to leave a comment and set it to RTBC π¬ Doing so now.
-
claudiu.cristea β
committed 2f538b32 on 3.0.x authored by
dxvargas β
Issue #3477873 by dxvargas, huzooka, claudiu.cristea: Return type for...
-
claudiu.cristea β
committed 2f538b32 on 3.0.x authored by
dxvargas β
Automatically closed - issue fixed for 2 weeks with no activity.