- Issue created by @quietone
- Status changed to Postponed: needs info
3 months ago 5:39pm 3 January 2025 - 🇦🇹Austria klausi 🇦🇹 Vienna
Works for me.
Note that if you are just testing one file you need to specify the module extension again (no idea why):
cd core ../vendor/bin/phpcs -p --extensions=module modules/search/search.moduleLet me know if that works!
- 🇳🇿New Zealand quietone
With the sniff enabled, for core, the many constants in module files are not reported as errors. Such as \Drupal\user\Controller\UserAuthenticationController::LOGGED_IN
- 🇦🇹Austria klausi 🇦🇹 Vienna
Hm, but that is a class constant. Of course class constants MUST NOT be prefixed with the module name as that would make them unnecessarily long. Class constants are already tied to a class with namespace, so no prefixing necessary.
The sniff Drupal.Semantics.ConstantName is about legacy global constants in the global scope that must not be used in modern Drupal anymore. (They cannot be autoloaded for example as far as I know)
We could add a new sniff to forbid global constants all together? Would probably make sense to open a new coding standards issue for that if we don't have it yet.
Does that answer your concern? Then I think we can close this.
- 🇳🇿New Zealand quietone
Yes, I think I just misinterpreted the error message and how 'module' is used. So, this is working as designed.