Blog - Add test coverage for applying on top of drupal_cms base

Created on 27 September 2024, about 1 month ago

Problem/Motivation

Ever since https://www.drupal.org/project/drupal_cms/issues/3474053 πŸ“Œ Remove drupal_cms_blog from the main recipe, make optional instead Needs work , the recipe no longer applies after applying the base (as a normal user would), but the tests are not covering this.

Steps to reproduce

Site install drupal_cms and afterwards try to apply blog recipe in any way.

Proposed resolution

Add test coverage for applying on top of base and fix issues that arise from that

πŸ“Œ Task
Status

Active

Component

Track: Blog

Created by

πŸ‡§πŸ‡ͺBelgium L_VanDamme

Live updates comments and jobs are added and updated live.
  • testing

    Used for Documentation issues related to testing and test development

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @L_VanDamme
  • First commit to issue fork.
  • Merge request !108Resolve #3477362 "Test optional recipes" β†’ (Merged) created by phenaproxima
  • Pipeline finished with Failed
    about 1 month ago
    Total: 416s
    #294767
  • Pipeline finished with Failed
    24 days ago
    Total: 342s
    #303363
  • Pipeline finished with Failed
    24 days ago
    Total: 325s
    #303370
  • Pipeline finished with Failed
    24 days ago
    Total: 65s
    #303380
  • Pipeline finished with Failed
    21 days ago
    Total: 824s
    #306536
  • Pipeline finished with Failed
    21 days ago
    Total: 802s
    #306555
  • Pipeline finished with Failed
    21 days ago
    Total: 1004s
    #306590
  • Pipeline finished with Failed
    21 days ago
    Total: 850s
    #306600
  • Pipeline finished with Failed
    21 days ago
    #306614
  • Pipeline finished with Failed
    21 days ago
    Total: 617s
    #306641
  • Pipeline finished with Failed
    21 days ago
    Total: 617s
    #306659
  • Pipeline finished with Success
    21 days ago
    Total: 704s
    #306690
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Well I sorta blew up the scope here, but I made changes I've been wanting to make for a while:

    • All the tests are now functional tests. This gives us a much clearer and more accurate picture of how the recipes actually work, individually and with each other.
    • The "optional" recipes are read from suggestions in the base recipe's composer.json. The optional recipes are no longer bundled with the base recipe, but are included in the project template.
    • Several recipes are now opting into the relaxed comparison with existing config. This was a judgment call that I had to make per recipe, in order to get it to play nice.

    If it passes tests, I'm merging this.

  • Pipeline finished with Success
    20 days ago
    Total: 630s
    #306708
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Skipped
    20 days ago
    #306714
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    What a slog. Glad to see the back of it.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024