- Issue created by @mogtofu33
-
mogtofu33 →
committed 8d11f145 on 1.0.x
Issue #3477078 by mogtofu33: Refactor IconFinder
-
mogtofu33 →
committed 8d11f145 on 1.0.x
Current IconFinder class is used to load definition value config > sources and extract a list of icons with support for wildcards {group} (simple metadata) and {icon_id} (icon id identifier, used for final icon id: definition_id:icon_id).
This class is hard to maintain and do not really handle well recursive and depth when using {group}.
This class should rely on Symfony\Component\Finder\Finder or Symfony\Component\Finder\Glob.
Current implementation for third party clean Icon packs works fine (Bootstrap, Feather, Hero, Phosphor...).
But problems emerge when trying to handle multiple paths to discover Drupal core icons.
In the meantime Drupal icons have a lot of duplicate filenames (grouped under color code folders), until now we simply decide to override, the lower source won, but perhaps it would be useful to handle custom icon_id? It seems it was the plan for a manual extractor, something like:
config:
sources:
- _ICON_ID_:_ICON_PATH_
Or is it too much a edge case?
The names problems can be simply solved by creating multiple definitions.
Still recurse problem must be addressed and the class rewritten.
Active
1.0
Code
Issue #3477078 by mogtofu33: Refactor IconFinder