- Issue created by @rupertj
- Merge request !65Return value for date facets as time from epoch in seconds from FacetResultParser. β (Merged) created by rupertj
- π¬π§United Kingdom rupertj Bristol, UK
Tests fail on code style at the moment (see #3477071). I've made the existing tests pass with the new code, but need to add a test case for the new functionality.
- π¬π§United Kingdom rupertj Bristol, UK
I've added unit test coverage for the new code to handle dates in FacetResultParser.
I also made the code look at the ISO 8601 date string that gets returned, instead of using the integer value. This means if for some reason we end up with the date with precision in seconds instead of milliseconds, the facet should still work.
The CI's failing on the next minor composer step, which looks to me like it's opensearch-php's issue to fix. They're discussing here: https://github.com/opensearch-project/opensearch-php/issues/199. (TLDR: opensearch-php via ezimuel/ringphp depends on react/promise ~2.0, composer 2.8 depends on react/promise ^3.2). Everything else passes though, so I think this is ready for a proper review.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Thanks for this. Almost good to go. That ringphp dependency looks like a major PITA.
- π¬π§United Kingdom rupertj Bristol, UK
Thanks for the review! Using DateTimeImmutable makes sense, so I've changed that.
-
kim.pepper β
committed 1bca3f1b on 3.x authored by
rupertj β
Issue #3477015: FacetResultParser returns incorrect values for date...
-
kim.pepper β
committed 1bca3f1b on 3.x authored by
rupertj β
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Committed to 3.x and 2.x. Thanks!
-
kim.pepper β
committed 35d1454e on 2.x authored by
rupertj β
Issue #3477015: FacetResultParser returns incorrect values for date...
-
kim.pepper β
committed 35d1454e on 2.x authored by
rupertj β
Automatically closed - issue fixed for 2 weeks with no activity.