Add types to all parameters

ptmkenny → changed the visibility of the branch type_parameters to hidden.

ptmkenny → changed the visibility of the branch type_all_the_things to hidden.

ptmkenny → changed the visibility of the branch type_parameters to active.

ptmkenny → changed the visibility of the branch type_parameters to hidden.

ptmkenny → changed the visibility of the branch type_parameters to active.

ptmkenny → changed the visibility of the branch type_parameters to hidden.

ptmkenny → changed the visibility of the branch parameter_types to hidden.

Wow, what a mess. For some reason, GitLab didn't show my latest commit in the original branch. Then subsequent branches created on that branch said "branch does not exist" when trying to make an MR. So I created a new branch through the UI and cherry-picked my commits onto that.

It seems GitLab is not running tests on new MRs at the moment. I'll come back to this later when things are up and running again.

ptmkenny → closed merge request !52

Let's bump the PHPStan level to 6 in the 3.2.x branch and add generic ignores for any array shape stuff to the phpstan.neon file.

@alexpott Ok, I'll go ahead and type the params, returns, and then update phpstan to level 6.

@ptmkenny if you bump it to 6 then gitlab ci will give you a nice list of things to fix :)

If you have field_encrypt installed in modules/field_encrypt then you can edit the phpstan.neon file and then run ../../vendor/bin/phpstan analyse --debug --autoload-file=../../vendor/autoload.php ./ to run PHPStan locally.

@alexpott Thanks! I have a local setup for phpstan; I want to get the unit tests green again and then I'll start working on phpstan.

All tests are passing, so I'm moving this to "Needs review."

Changed some small things:

1. Moved to an assert instead of an instanceof check as we'd want it to break if $event->getConfig() did not return what we expect.
2. Changed the hook return type back to undefined as this is a super tricky hook that is only interested if you return a FALSE.

Automatically closed - issue fixed for 2 weeks with no activity.