Missing text format: full_html

Created on 25 September 2024, about 2 months ago

The View of all existing registration codes uses the full_html filter format to display a message when there are no registration codes.

The full_html filter format is included with the 'standard' Drupal install profile, along with many others, but some don't include it. Regardless, there is no need for us to use full_html here because we are just displaying plain text.

We should change the View to use the default plain_text filter format, and update the View configuration to keep up with other changes made to Views.

πŸ“Œ Task
Status

Active

Version

2.0

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tr
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Here is a new export of the View with full_html changed to plain_text. There seem to be a lot of differences at first glance, but the vast majority are because core Views has rearranged the default ordering of the configuration file. If you sort the old and new files then compare them there are no functional changes.

  • πŸ‡©πŸ‡ͺGermany neurer

    Works for me.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    I'm going to re-roll this with just minimal changes to the view configuration, because the more-extensive changes above conflict with the ongoing work in ✨ Display all users which used the current regcode. Needs review . This part can always be done later.

    I'm also writing a hook_update_N() for the change and a test for the hook_update_N(). Even though this is a little change, from full_html to plain_text, we need to ensure existing sites get that change and we need the test case to ensure this hook does what we intend for it to do.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Core Views update fails with the error below when running the D10 update tests included in this MR. But everything passes in D11. My conclusion is that the Views configuration we ship with this module is badly outdated, so I will have to first make commit to the View before I can finish this current issue.

    Deprecated function: mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Core\Config\Entity\Query\Condition->compile() (line 39 of core/lib/Drupal/Core/Config/Entity/Query/Condition.php).
    
    Drupal\Core\Config\Entity\Query\Condition->compile() (Line: 88)
    Drupal\Core\Config\Entity\Query\Query->execute() (Line: 307)
    Drupal\Core\Config\Entity\ConfigEntityBase->preSave() (Line: 293)
    Drupal\views\Entity\View->preSave() (Line: 528)
    Drupal\Core\Entity\EntityStorageBase->doPreSave() (Line: 483)
    Drupal\Core\Entity\EntityStorageBase->save() (Line: 257)
    Drupal\Core\Config\Entity\ConfigEntityStorage->save() (Line: 354)
    Drupal\Core\Entity\EntityBase->save() (Line: 614)
    Drupal\Core\Config\Entity\ConfigEntityBase->save() (Line: 192)
    Drupal\Core\Config\Entity\ConfigEntityUpdater->doOne() (Line: 147)
    Drupal\Core\Config\Entity\ConfigEntityUpdater->update() (Line: 149)
    views_post_update_pager_heading() (Line: 243)
    update_invoke_post_update() (Line: 296)
    _batch_process() (Line: 187)
    _batch_progress_page() (Line: 87)
    _batch_page() (Line: 195)
    Drupal\system\Controller\DbUpdateController->handle()
    call_user_func_array() (Line: 115)
    Drupal\Core\Update\UpdateKernel->handleRaw() (Line: 76)
    Drupal\Core\Update\UpdateKernel->handle() (Line: 27)
    
    Post updating views
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • Pipeline finished with Skipped
    about 1 month ago
    #309018
    • tr β†’ committed b27b2401 on 2.0.x
      Issue #3476833 by tr: Missing text format: full_html
      
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • πŸ‡©πŸ‡ͺGermany neurer

    There is no way to run/test this on D11 before #3476179 πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active is fixed and committed.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    I'm not sure how much Drupal development experience you have, so I'm going to write some general advice for anyone who encounters this issue in the future.

    When an issue is marked fixed, the fix has already been made and already exists in the development version of the module. Testing is always appreciated, but there is no need to test it any more once the issue is fixed, and you can "run" it simply by using the development version of the module.

    For outstanding issues that haven't been "fixed" yet, like πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active , you can download the patch from that issue and apply it to the development version of the module. I try to keep all those other issues up-to-date by rebasing the merge requests so that the patch will always apply to -dev. And that issue in particular *is* up-to-date and has been rebased. So if you need that issue, simply apply the patch from

    With this module, I worked on the current issue first because the changes here do not affect the work on either ✨ Display all users which used the current regcode. Needs review or πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active . The order I work on issues is important because if I do it in the wrong order then it causes a LOT more work for me. And I maintain this module as a volunteer maintainer, using my spare time. I am not paid and this is not part of my day job.

    My plan is to work on getting ✨ Display all users which used the current regcode. Needs review finished next. Then I will work on πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active . The proposed patches in both issues conflict with each other, and both are not quite right so I will need to so work on them - I can't just commit them as-is.

  • πŸ‡©πŸ‡ͺGermany neurer

    I'm going to ignore the first paragraph and respectfully suggest amending your approach:

    1. Do not publish stable releases and label them as suited for a specific version if they have no (as in NONE, ZERO, NULL) functionality.
    2. This issue is a child issue of #3476179 πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active and should have been treated and labeled as such.
    3. Machine testing is always inferior to user feedback -- as in " That settings form is one of the very few things that is tested in this module, and the tests show no errors accessing that page. πŸ› Symfony\Component\Routing\Exception\RouteNotFoundException Active "
    4. Do not mark issues as Needs review if you do not wish/require user input. Leave them as active.
    5. Always encourage and enable testing by users.
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024