Fix the issues reported by PHP_CodeSniffer

Created on 24 September 2024, about 2 months ago

Problem/Motivation

FILE: modules\processing\config\processing.settings.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
2 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: modules\processing\css\drupal.processing.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: modules\processing\processing.install
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------
20 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
23 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: modules\processing\processing.libraries.make.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: modules\processing\processing.libraries.yml
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: modules\processing\processing.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: modules\processing\processing.module
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------
13 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: modules\processing\processing.routing.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: modules\processing\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 101 characters
23 | WARNING | Line exceeds 80 characters; contains 145 characters
24 | WARNING | Line exceeds 80 characters; contains 109 characters
25 | WARNING | Line exceeds 80 characters; contains 95 characters
29 | WARNING | Line exceeds 80 characters; contains 115 characters
33 | WARNING | Line exceeds 80 characters; contains 92 characters
34 | WARNING | Line exceeds 80 characters; contains 92 characters
35 | WARNING | Line exceeds 80 characters; contains 102 characters
39 | WARNING | Line exceeds 80 characters; contains 194 characters
47 | WARNING | Line exceeds 80 characters; contains 147 characters
51 | WARNING | Line exceeds 80 characters; contains 93 characters
53 | WARNING | Line exceeds 80 characters; contains 133 characters
----------------------------------------------------------------------

FILE: modules\processing\src\Form\SettingsForm.php
---------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------
49 | ERROR | [x] The static declaration must come after the visibility declaration
114 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------

FILE: modules\processing\src\Plugin\Filter\FilterProcessing.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
62 | ERROR | [x] The static declaration must come after the visibility declaration
217 | ERROR | [x] The static declaration must come after the visibility declaration
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: modules\processing\tests\src\Unit\Plugin\Filter\FilterProcessingTest.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
109 | ERROR | [ ] The array declaration extends to column 165 (the limit is 120). The array content should be split up over multiple lines
112 | ERROR | [ ] The array declaration extends to column 184 (the limit is 120). The array content should be split up over multiple lines
113 | ERROR | [ ] The array declaration extends to column 194 (the limit is 120). The array content should be split up over multiple lines
141 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
143 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run phpcs command to get the drupal coding standard issues.

Proposed resolution

Many of the issues can be fixed by running the phpcbf command. For the remaining ones, we will need to manually address and then commit these changes before pushing them.

πŸ“Œ Task
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024