- Issue created by @stefan.korn
- Merge request !76Issue #3476157: Checkboxes and radios should conform to Bootstrap examples → (Open) created by stefan.korn
- 🇦🇺Australia jannakha Brisbane!
@stefan.korn thanks for your contribution!
After application of patch:
+ HTML has required classes:
+ removed margin on description:
before:
after:
Unfortunately,
css/components
is a volatile folder and can be overwritten by updates coming fromweb/core/themes/starterkit_theme/css/components
(see Starterkit theme - Tracking upstream changes → )Please make update to scss in
web/themes/contrib/bootstrap5/scss/drupal/_forms.scss
- 🇩🇪Germany stefan.korn Jossgrund
@jannakha: thanks for reviewing this.
Regarding css/components/form.css: We could do the changes instead in scss/drupal/_forms.scss, but this does have some caveats too I suppose. One would need to overwrite the CSS from form.css in forms.scss, maybe something like
margin-left: inherit;
. While this is possible, seems not to be the cleanest way.In addition this would somehow still depend on form.css. If for example the CSS selectors are changed in form.css, the fix in forms.scss might not apply anymore. This is kind of a hidden dependency.
So maybe think about if you might not still prefer the way via form.css. Maybe one could add a line with comment like "removed unnecessary margin for description" and then if you incorporate upstream changes from starterkit you would see this line in a git diff and can keep track of the change this way. This would of course not work if you incorporate the upstream changes automatically without reviewing. In that case we would probably need to do it elsewhere like in forms.scss