- Issue created by @daffie
- Status changed to Needs review
3 months ago 12:41pm 19 September 2024 - Status changed to RTBC
3 months ago 1:38pm 19 September 2024 - ๐บ๐ธUnited States smustgrave
I'm having to do the exact same thing on a number of modules but refactors seem to be good 1to1
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
Love thisโฆ I wonder how far would we be from deprecating usage of hardcoded static queries from non-test, non-database core code. +1
- ๐บ๐ธUnited States smustgrave
Not sure if there is a page somewhere but would be cool to see the all sql queries keywords with their dyanmic counterparts
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
#6 well the Database API documentation and https://www.drupal.org/docs/8/api/database-api/dynamic-queries โ in particular covers that pretty well already, IMO
- Status changed to Needs review
3 months ago 9:09pm 20 September 2024 - ๐ฌ๐งUnited Kingdom catch
OK I was expecting a big MR, but this is actually very minimal.
Not 100% sure about dblog though, wouldn't it make more sense to provide mongodb_log since I would imagine the stored format of the messages could then be optimised?
- Status changed to RTBC
3 months ago 7:30am 21 September 2024 - ๐ณ๐ฑNetherlands daffie
@catch: We have changed a lot of hardcoded SQL queries to dynamic queries in the past. If you want, I will go and search for those issues. These are the hardcoded queries that are left. The remaining ones are mostly in Drupal's critical path.
I am at the moment still in the phase of getting Drupal on MongoDB to support all the features. Drupal on MongoDB now is at a 99% pass rate for the CI pipeline ๐ Drupal on MongoDB (the full PR) Active . Sooner or later I will get the phase where MongoDB specific improvements will be added. I am still not at the point where I have an official go for Drupal on MongoDB from the Drupal Core committer team. :) - ๐ฌ๐งUnited Kingdom catch
We have changed a lot of hardcoded SQL queries to dynamic queries in the past.
Yes I remember that, I just though it would be worse than this even with those issues having landed already ;) Remaining ones are in database cache backend etc.
Even though I'm not sure dblog-on-mongodb makes sense in practice, it doesn't hurt to make it work. Committed/pushed to 11.x, thanks!
- Status changed to Fixed
3 months ago 7:46am 21 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.