Contrib.social

Coding Standard Issues

Open on Drupal.org ā†’
Created on 18 September 2024, 7 months ago
Updated 20 September 2024, 7 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: .../web/modules/custom/native_lazy_loading/native_lazy_loading.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
21 | ERROR | [x] Expected 1 blank line after function; 2 found
48 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
87 | ERROR | [x] Data types in @var tags need to be fully namespaced
131 | ERROR | [ ] Missing short description in doc comment
132 | ERROR | [ ] Missing parameter comment
134 | ERROR | [ ] Description for the @return value is missing
136 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
150 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
163 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/native_lazy_loading/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 95 characters
9 | WARNING | Line exceeds 80 characters; contains 296 characters
11 | WARNING | Line exceeds 80 characters; contains 272 characters
17 | WARNING | Line exceeds 80 characters; contains 198 characters
19 | WARNING | Line exceeds 80 characters; contains 118 characters
21 | WARNING | Line exceeds 80 characters; contains 82 characters
24 | WARNING | Line exceeds 80 characters; contains 122 characters
28 | WARNING | Line exceeds 80 characters; contains 181 characters
33 | WARNING | Line exceeds 80 characters; contains 371 characters
-----------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Needs review

Version

1.1

Component

Code

Created by

šŸ‡µšŸ‡ŖPeru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Assigned to alyaj2a
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡ŖPeru alyaj2a
  • Merge request !4Coding standard issues - #3475328 ā†’ (Open) created by alyaj2a
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡ŖPeru alyaj2a
  • Comment 6 months ago ā†’
    šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @alyaj2a,

    Thank you for providing an MR. I applied MR!4, it was applied smoothly and fixed all the phpcs issues.

    āžœ  native_lazy_loading git:(1.1.x) curl https://git.drupalcode.org/project/native_lazy_loading/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7774    0  7774    0     0  10194      0 --:--:-- --:--:-- --:--:-- 10188
patching file README.md
patching file native_lazy_loading.module
āžœ  native_lazy_loading git:(1.1.x) āœ— ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml native_lazy_loading
āžœ  contrib git:(main) āœ—

    Thank you.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024