ModalFormTest sometimes failed

Created on 18 September 2024, 3 months ago

Problem/Motivation

Sometimes ModalFormTest failed because of "assertWaitOnAjaxRequest" failed. This happens because of core changes here 📌 Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest() Fixed .

@bnjmnm explaining 📌 Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest() Fixed :

So for tests that were previously passing and now fail on assertWaitOnAjaxRequest(), the first thing to try is removing the call entirely. It was very common to add these calls in places where they were not needed, where they were used for waiting on a JS operation to complete that wasn't necessarily something that used the Drupal AJAX API.

I removed "assertWaitOnAjaxRequest" and test passed all the time

Steps to reproduce

Run ModalFormTest multiple times. I don't know another way :(

Proposed resolution

Remove "assertWaitOnAjaxRequest" from test

🐛 Bug report
Status

Closed: works as designed

Version

4.0

Component

Flag core

Created by

ivnish Kazakhstan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024