- Issue created by @traviscarden
- First commit to issue fork.
- Merge request !317Resolve #3474732 invalid props should not be written to model β (Merged) created by bnjmnm
- Assigned to bnjmnm
- πΊπΈUnited States bnjmnm Ann Arbor, MI
This will likely be dormant for a week or so while DrupalCon happens. The plan is nything in the schemas that can be enforced by html5 validation will be added as attributes to the form inputs. Some things such as type enforcement in some element types can't be achieved this way (select is just gonna store strings even if we want numbers) - but letting the browser enforce where possible should help minimize the overall spaghetti.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
99% done -
FieldTypeUninstallValidatorTest
is failing and I'm not yet sure why. Unassigning myself to open this up to contributors who have had more exposure to that test and might be able to figure it out more quickly. In the meantime I'll keep debugging to see what is happening. - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ted knows that test the best.
- First commit to issue fork.
- πΊπΈUnited States tedbow Ithaca, NY, USA
FieldTypeUninstallValidatorTest
was failing it tests we can uninstall thelink
module after we remove all uses in XB fields. Now thatlink
is a dependency of XB we get an error after remove all the links uses because it tries to also uninstall XB but its fields are in use on bundles.Fix the test to make sure we don't get "link" at ll in the uninstall error message at after we have removed all the uses of the link field
there is merge error now in one of the .js tests so assigning back to @bnjmnm
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Sorry for the chungus MR, but it is ready.
- π¬π§United Kingdom jessebaker
I've done a bit of manual testing and found some issues around entering numbers. Would you prefer to address here, or else I can raise them as new issues?
On a required, string, field (E.g. the Heading field on the default Hero component)
- Entering a number fails validation but I would expect my entered value to be cast to a string. What if I want a heading that says "911" for example.
- If I select all the text in an input and press space, the value is immediately changed to a 0 and then the app crashes.
- Typing in -0 also crashes the app. (possibly same issue as 2)
- After typing a number, I can't press space (e.g. If I wanted the heading to be "4 person menu"
On a URI field (E.g. the CTA 1 Link field on the default Hero component)
- Typing 0 crashes the app.
- After typing a number, I can't press space (e.g. If I wanted the heading to be "4 person menu"
- πΊπΈUnited States tedbow Ithaca, NY, USA
needed to merge 0.x but now test are failing
- First commit to issue fork.
- πΊπΈUnited States tedbow Ithaca, NY, USA
Looks like this needs @wim leers or @f.mazeikis approval to merge
-
bnjmnm β
committed 31e46aa5 on 0.x
Issue #3474732 by bnjmnm, tedbow, jessebaker, balintbrews, traviscarden...
-
bnjmnm β
committed 31e46aa5 on 0.x
- Issue was unassigned.
- Status changed to Fixed
25 days ago 1:34pm 27 November 2024 Automatically closed - issue fixed for 2 weeks with no activity.