- Issue created by @jayesh_vijay
- Status changed to Needs work
3 months ago 6:19am 18 September 2024 - 🇮🇳India riddhi.addweb
I applied the MR [16], but it seems like the issues are still not resolved, Errors are still displayed after applying the MR. Please review it. Attaching the SS for the same.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 7:21am 18 September 2024 - 🇮🇳India sarwan_verma
Hi,
I have resolved all PHPCS issues and merged them into MR!16 for better clarity.
I have also attached a screenshot for your reference.Kindly review it.
Thanks! - Status changed to Needs work
3 months ago 11:35am 18 September 2024 - 🇮🇳India riddhi.addweb
When the user applies the patch It displays Patch errors after applying the patch. [MR16]
Checking patch src/Services/FacebookPostCollector.php... warning: src/Services/FacebookPostCollector.php has type 100755, expected 100644 error: while searching for: use Symfony\Component\HttpFoundation\Response; /** * Class FacebookPostCollector. * * @package Drupal\socialfeed */ error: patch failed: src/Services/FacebookPostCollector.php:8 error: src/Services/FacebookPostCollector.php: patch does not apply Checking patch templates/socialfeed-instagram-post-video.html.twig... warning: templates/socialfeed-instagram-post-video.html.twig has type 100755, expected 100644 Checking patch templates/socialfeed-twitter-post.html.twig... warning: templates/socialfeed-twitter-post.html.twig has type 100755, expected 100644