CSS issue max-width mobile

Created on 14 September 2024, 7 months ago

width: 745, -> 95%

mobile is not working

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium michiellucas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @michiellucas
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks @michiellucas! Using a relative width makes sense for responsive. Could you prepare a Merge-Request instead of the patch?
    Maybe there are even better options for the value? I'm unsure...

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica
  • Assigned to TomTech
  • Status changed to Closed: outdated about 1 month ago
  • πŸ‡ΊπŸ‡ΈUnited States TomTech

    Hi!

    Thanks for the report!

    Both width and maxWidth were set in the js when the dialog was declared. This provided a reasonable desktop width, along with the max width for mobile.

    When the jQuery dialog was replaced by the Drupal core dialog, it appears support for the maxWidth property was not carried over.

    Setting the width to 90% might work on mobile, but is way too wide for desktop, especially a wide one.

    With the changes in theming in a recent MR, #3511910: Cleanup Theming β†’ , the width is still set to 745 for desktop/laptop. max-width is now set in the css to handle this. (You can, of course, style to your desire in your theme!)

Production build 0.71.5 2024