[1.0.0-beta1] Remove IconDefinition::DEFAULT_TEMPLATE

pdureau → credited mogtofu33 → .

We also do 📌 [1.0.0-beta1] Clean *.ui_icons.yml Needs work in this merge request.

Nearl yfinished, we jsut need to run prettier on the heavily edited YAML

I have run prettier on modified YAML instead of eslint --config=./.eslintrc.json --no-error-on-unmatched-pattern --ext .yml --resolve-plugins-relative-to ./node_modules but the pipeline is OK.

However, one phpunit failure:

1) Drupal\Tests\ui_icons\Kernel\Plugin\IconPackManagerKernelTest::testListIconPackOptions
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'test_local_files' => 'Local files (8)'
+    'test_no_settings' => 'No Settings (5)'
     'test_local_svg' => 'SVG manual (7)'
     'test_local_svg_sprite' => 'Small sprite (5)'
-    'test_no_settings' => 'No Settings (5)'
 )

Do some tweaking to have nice previews

So,

• we keep Pierres's 2 first commits a a startign point for siplifictaion
• we get rid of Pierre's third commti because we have a better solution than CSS tweaking
• we ignore settings in Drupal config schema
• we don't promote "size" as a global variable, it stays as a icon pack specific variable
• We introduce a new preview_template property to icon definition, to render preview with an expected size (which one? 96px? 48px ?):
  • which will be optional for renderable based on IMG or SVG HTML elements, because there will have a "default default template" with IMG and source + icon_id are enough to build it, and we can leverage WIDTH & HEIGHT HTML attributes
  • which will be expected for renderable based on CLASS or DATA- HTML attributes, because size management is very specific

Also, let's add this pack:

font_awesome_names:
  label: Font Awesome [Icon name]
  description: The Internet's icon library and toolkit, used by millions of designers, developers, and content creators. 
  links:
    - https://docs.fontawesome.com/web/add-icons/svg-unicodes 
  extractor: svg
  config:
    sources:
      - /libraries/fontawesome/svgs/{group}/{icon_id}.svg
  settings:
    size:
      title: "Size"
      type: "integer"
      default: 32
  template: >
    <i class="fa-solid fa-{{ icon_id }}"></i>

Fixed in 📌 [Meta Beta release] Clean code, no default template, better preview Fixed .

Feather example will be added to UI Icons example.https://gitlab.com/ui-icons/ui-icons-example

mogtofu33 → closed merge request !23