Contrib.social

Add D11 support for 2.1.x-dev

Open on Drupal.org →
Created on 13 September 2024, 3 months ago

Problem/Motivation

There are some legitimate test failures that only occur in 2.1.x-dev against 11.x core. Let's get them researched and rectified.

Steps to reproduce

1) Drupal\Tests\oembed_lazyload\Functional\LazyloadOEmbedFormatterPlaceholderTest::testPlaceholders with data set "Placeholder dimensions with local responsive image style" (['automatic', 'local_asset', 'responsive_image_style', 'test'], '<img class="oembed-lazyload__...meo.">')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/47467898/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=uHWcZe_8 1x" width="88" height="100" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
+'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/47467898/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=uHWcZe_8 1x" width="1" height="1" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
/builds/project/oembed_lazyload/tests/src/Functional/LazyloadOEmbedFormatterPlaceholderTest.php:205
2) Drupal\Tests\oembed_lazyload\Functional\LazyloadOEmbedFormatterPlaceholderTest::testPlaceholders with data set "Absolute maxima dimensions with local responsive image style" (['absolute_maxima', 'local_asset', 'responsive_image_style', 'test'], '<img class="oembed-lazyload__...meo.">')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/81725950/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=0BpfzVK0 1x" width="88" height="100" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
+'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/81725950/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=0BpfzVK0 1x" width="1" height="1" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
/builds/project/oembed_lazyload/tests/src/Functional/LazyloadOEmbedFormatterPlaceholderTest.php:205
3) Drupal\Tests\oembed_lazyload\Functional\LazyloadOEmbedFormatterPlaceholderTest::testPlaceholders with data set "Legacy dimensions with local responsive image style" (['legacy', 'local_asset', 'responsive_image_style', 'test'], '<img class="oembed-lazyload__...meo.">')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/63755040/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=M4kKrnI9 1x" width="88" height="100" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
+'<img class="oembed-lazyload__thumbnail" loading="lazy" srcset="/web/sites/simpletest/63755040/files/styles/test/public/oembed_thumbnails/2024-09/M_heqwmt2fqlEmdRbu0DOAyeIAwNwQqgFNthzgdisxw.png?itok=M4kKrnI9 1x" width="1" height="1" src="data:image/gif;base64,R0lGODlhAQABAIABAP///wAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="Watch Drupal Rap Video - Schipulcon09 on Vimeo.">'
/builds/project/oembed_lazyload/tests/src/Functional/LazyloadOEmbedFormatterPlaceholderTest.php:205

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

2.1

Component

Code

Created by

🇺🇸United States luke.leber Pennsylvania

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @luke.leber
  • Status changed to Needs review 3 months ago
  • Comment 3 months ago →
    ananya.k

    Please refer to attached patch.

  • Status changed to Needs work 3 months ago
  • Comment 3 months ago →
    🇺🇸United States luke.leber Pennsylvania

    Hi ananya, thanks for the comment, but there are a couple problems:

    1. Drupal.org only supports merge request workflows now [in order to run automated testing].
    2. The problems with the 2.1.x branch are documented in the issue summary. Changing the version identifiers is not a solution here, as there are real test failures to resolve.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024