- Issue created by @pingwin4eg
- 🇭🇺Hungary Gábor Hojtsy Hungary
So the text is not in line with the requirement?
elseif ($database_type == 'sqlite') { $database_type_full_name = 'SQLite'; $requirement = $this->t('When using SQLite, minimum version is 3.26'); if (version_compare($version, '3.45') >= 0) { $class = 'color-success'; } else { $status = FALSE; $class = 'color-error'; } }
I see it here.
- 🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦
Ah, so the actual minimum is different. Well, then yes, the text is wrong. The version value in it should be replaced with a placeholder.
- 🇺🇦Ukraine pingwin4eg Zaporizhia 🇺🇦
And looking at the form code, it's not only with sqlite. Other DB types, drush also have versions hardcoded in strings. The correct implementation is with the PHP version check.
- Merge request !103Fix minimum SQLite version, use variable to unify it → (Merged) created by Gábor Hojtsy
-
gábor hojtsy →
committed f7c64657 on 4.x
Issue #3473768 by gábor hojtsy, pingwin4eg: Fix the SQLite version...
-
gábor hojtsy →
committed f7c64657 on 4.x
Automatically closed - issue fixed for 2 weeks with no activity.