- Issue created by @ekes
- Merge request !46Issue #3473537: Update schema for properties available in LeafletSettingsElementsTrait. → (Open) created by ekes
- Status changed to Needs review
4 months ago 10:17am 11 September 2024
We've been getting a schema missing error
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.localgov_directory_channel with the following errors: views.view.localgov_directory_channel:display.embed_map.display_options.style.options.leaflet_popup.view_mode missing schema
caused by exported view leaflet_map style
leaflet_popup:
value: '#rendered_view_fields'
options: '{"maxWidth":"300","minWidth":"50","autoPan":true}'
view_mode: full
(see also reproduce)
Example view on the PR https://github.com/localgovdrupal/localgov_directories/pull/336 specifically https://github.com/localgovdrupal/localgov_directories/pull/336/commits/...
Looking at the code it's just the view_mode that's added at the moment. So add that to the schema. But as it's using the LeafletSettingsElementTrait it could set and contain: value, options, view_mode, control and content https://git.drupalcode.org/project/leaflet/-/blob/999f59251a6fa8f04718c1... so a 'belt-and-braces' approach would be to update the schema in places the Trait is used to accept those properties.
Add potential leaflet_popup properties to the schema where the LeafletSettingsElementsTrait is used. MR to follow.
Needs review
10.2
Code