Contrib.social

Fix two intermittent e2e fails

Open on Drupal.org →
Created on 10 September 2024, 4 months ago
Updated 11 September 2024, 4 months ago

Overview

FAIL 1 REASON
useSyncIframeHeightToContent.ts intermittently fails because in window.requestAnimationFrame inside resizeIframe it is assuming some variables are objects that can - at times - be undefined.
FAIL 2 REASON
Viewport.tsx has an attribute that verifies an iframe is initialized. It is set to false any time a specific useEffect is triggered, then set to true (which is required by e2e) when the onload callback completes.

The useEffect that sets this to false includes a dependency on size and height, neither of which triggers a new onload. The result is triggering the useEffect thus switching the attribute to false but without anything that triggers the necessary onload

Proposed resolution

1. Better checks for truthiness in window.requestAnimationFrame
2. Remove the size dependency in that dang useEffect

User interface changes

🐛 Bug report
Status

Fixed

Component

Page builder

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024