- Issue created by @herved
- 🇧🇪Belgium herved
Phpunit is failing because there is a broken/wrong serialized value in modules/contrib/entity_legal/tests/fixtures/update/install_entity_legal.php:88
We can verify this by throwing the exception in
\Drupal\Core\KeyValueStore\DatabaseStorage::getMultiple
instead of muting it. See this https://3v4l.org/mr8AW
It fails on PHP 8.3 but not on lower versions, which explains the issue.
I will fix it in this MR. - Status changed to Needs review
7 months ago 9:21pm 10 September 2024 - Status changed to Needs work
7 months ago 6:55am 11 September 2024 - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Looks good, thank you!
Here are some issues I think we can fix:
- Let's enforce PHPCS, PHPStan by adding to
.gitlab-ci.yml
:
phpstan: allow_failure: false phpcs: allow_failure: false
- Create a followup to fix and enforce cspell too
- Resolve the issue with Drupal 11 failure in PHPStan and PHPUnit. If we cannot add
: string
to our method, let's drop it and create our own::randomLowercaseMachineName()
- Let's enforce PHPCS, PHPStan by adding to
- 🇧🇪Belgium herved
Thanks @Claudiu,
I propose to fix cspell here directly, but I can always create a new issue and move the commit there if you prefer.
Most of those are obvious except I added exclusions for "please" from\Drupal\entity_legal\Plugin\EntityLegal\Message::execute
, just in case site owners translated the string. - Status changed to Needs review
7 months ago 2:32pm 11 September 2024 -
claudiu.cristea →
committed c1ead291 on 4.0.x authored by
herved →
Issue #3473330 by herved, claudiu.cristea: Fix tests and restore...
-
claudiu.cristea →
committed c1ead291 on 4.0.x authored by
herved →
- Status changed to Fixed
7 months ago 2:57pm 11 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.