- Issue created by @f.mazeikis@gmail.com
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
This isn't quite what I meant. I meant something much simpler!
Starting to use validation constraints for SDC
*.component.yml
files would be going too far โ that's what the SDC JSON schema is already doing, these are simply the additional requirements that XB has.Maybe we could convert that all to validation constraints, but that seems overkill ๐
- ๐ฎ๐ณIndia Akhil Babu Chengannur
akhil babu โ made their first commit to this issueโs fork.
- Merge request !296Issues/3473289: Add validation constraint for the status field. โ (Open) created by Akhil Babu
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Added a validation constarint to check if 'status' is TRUE.
Now updating the tests - Status changed to Needs work
7 days ago 11:23am 12 September 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
@kristen pol in #4: that
iff
wasn't a typo: https://en.wikipedia.org/wiki/If_and_only_if@akhil babu Thanks for getting started on this! But you only added a constraint that simply refuses to accept
false
as a value. That's not what's described in the issue summary:# @todo Write validation constraint that verifies that IF this value is `true`, that \Drupal\experience_builder\Plugin\ComponentPluginManager::componentMeetsRequirements() also is met.
You're well on your way to that though โ you need to update the validator you wrote to call that method ๐
- Assigned to Akhil Babu
- Issue was unassigned.
- Status changed to Needs review
3 days ago 9:51am 17 September 2024 - ๐ฎ๐ณIndia Akhil Babu Chengannur
Thanks for the guidance @wim leers. I have updated the validator code.
Drupal\Tests\experience_builder\Kernel\ComponentTest::testObsoleteStatusHandling
still fails. I am not sure if this test should be removed or updated. Moving to needs review for feedback.