Contrib.social

Replace DB- with entity-query in EntityReferenceRevisionsOrphanPurger::deleteOrphansBatchOperation()

Open on Drupal.org →
Created on 8 September 2024, 4 months ago

Problem/Motivation

In \Drupal\entity_reference_revisions\EntityReferenceRevisionsOrphanPurger::deleteOrphansBatchOperation() there's a @todo Replace with an entity query on all revisions with a revision ID condition after https://www.drupal.org/project/drupal/issues/2766135..

https://www.drupal.org/project/drupal/issues/2766135 → Landed quite a while ago.

Steps to reproduce

Proposed resolution

As said in the @todo: Replace with an entity query on all revisions with a revision ID condition.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @spokje
  • Merge request !56First stab. → (Open) created by spokje
  • Pipeline finished with Failed
    4 months ago
    Total: 278s
    #277086
  • Pipeline finished with Failed
    4 months ago
    Total: 395s
    #277094
  • Pipeline finished with Failed
    4 months ago
    Total: 146s
    #277098
  • Pipeline finished with Success
    4 months ago
    Total: 1391s
    #277122
  • Comment 4 months ago →
    🇳🇱Netherlands spokje
  • Comment 4 months ago →
    🇳🇱Netherlands spokje

    Since https://www.drupal.org/project/drupal/issues/2766135 → was added to D8.9 and upwards, we aren't breaking BC since this module supports coree 9/10/11.

    We can drop the DI of the $database in \Drupal\entity_reference_revisions\EntityReferenceRevisionsOrphanPurger::__construct.

    I tried to follow the deprecation policy, but am better at that in core than in contrib, so I might be overdoing it and/or making mistakes there.
    I didn't add union-typing to the constructor, since that's only PHP 8+.

  • Pipeline finished with Success
    4 months ago
    Total: 285s
    #277140
  • Issue was unassigned.
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇳🇱Netherlands spokje
  • Comment 4 months ago →
    🇳🇱Netherlands spokje
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇨🇭Switzerland berdir Switzerland
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024