Fix the issues reported by PHP_CodeSniffer

Created on 6 September 2024, 7 months ago
Updated 7 September 2024, 7 months ago
📌 Task
Status

Active

Version

6.1

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Assigned to alyaj2a
  • 🇵🇪Peru alyaj2a

    Hello, I uploaded all the corrections, except these.
    In this case, I need change ta names ta functions because is not in lowerCamel format, a example: computeCKEditor5PluginSubsetConfiguration => computeCkeditor5PluginSubsetConfiguration

    FILE: .../web/modules/custom/linkit/src/Plugin/CKEditor4To5Upgrade/Linkit.php
    -------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    -------------------------------------------------------------------------------------------------
    27 | ERROR | Public method name "Linkit::mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem" is
    | | not in lowerCamel format
    34 | ERROR | Public method name "Linkit::mapCKEditor4SettingsToCKEditor5Configuration" is not
    | | in lowerCamel format
    59 | ERROR | Public method name "Linkit::computeCKEditor5PluginSubsetConfiguration" is not in
    | | lowerCamel format
    -------------------------------------------------------------------------------------------------

    In this case there are thow name classes into condicionals, and the issue say: Class name doesn't match filename; expected "class UpgradePathCompletenessTest".

    -------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------
    14 | ERROR | Class name doesn't match filename; expected "class UpgradePathCompletenessTest"
    -------------------------------------------------------------------------------------------------

    Help me please, I don't know what to do with these remaining issues. Thanks.

  • Issue was unassigned.
  • Status changed to Needs work 7 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Active 7 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    (A merge request was not yet created. That is why I changed the status to Active.)

Production build 0.71.5 2024