Contrib.social

Drupal 11 Compatibility

Open on Drupal.org →
Created on 6 September 2024, 4 months ago
Updated 20 September 2024, 3 months ago

Problem/Motivation

This module needs to be upgraded to allow for Drupal 11 compatibility

For sure fails with both changes needed to .info and from PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress --error-format=gitlab > phpstan-quality-report.json || true
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/SettingsForm.php                                             
 ------ ---------------------------------------------------------------------- 
  44     Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1  
         parameter, 2 required.                                                
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 1 error

See this change record https://www.drupal.org/node/3404140 →

Pretty sure we can get away without overloading the constructor by using $this->container()->get('entity_type.manager') down where we are looking for it in buildForm.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States generalredneck

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024