- Issue created by @Rob Holmes
- Status changed to Needs work
5 months ago 1:42pm 5 September 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Thanks. This also needs to be added to an
status_dashboard_client.api.php
file with an example of how to implement the hook. - 🇬🇧United Kingdom Rob Holmes
Added status_dashboard_client.api.php with a guess at its required contents.
- Status changed to Needs review
4 months ago 10:41am 17 September 2024 - Assigned to aylis
- Status changed to Active
about 1 month ago 12:26pm 17 December 2024 - 🇧🇾Belarus aylis
@rob holmes, thank you for your proposition and work!
Feel free to review MR, I've added changes there from your most recent patch with minor style fixes - 🇧🇾Belarus aylis
Changes were merged to 2.0.x. They will be included into coming release.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
To be honest, I find the documentation not sufficient. If I were new to the module and read
Alters the json response sent from status_dashboard_client.check.
I still have no clue as to what it's doing.
Also code nit, but one should not mix and match snakecase and camelcase in one file.
- 🇧🇾Belarus aylis
@bramdriesen, thanks for your remarks! I've updated this issue fork and created new MR. Can you have a look and tell me if you find description added there sufficient?
-
bramdriesen →
committed 5cb053b6 on 2.0.x authored by
aylis →
Issue #3472318 by aylis, rob holmes, bramdriesen: Add a module alter to...
-
bramdriesen →
committed 5cb053b6 on 2.0.x authored by
aylis →
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Thanks @aylis that looks a lot better! Merged.
Automatically closed - issue fixed for 2 weeks with no activity.