- Issue created by @eduardo morales alberti
- Merge request !10Issue #3472291 by eduardo morales alberti: Override the menu links on the pre... → (Open) created by eduardo morales alberti
- Status changed to Needs review
4 months ago 10:37am 5 September 2024 - 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Previously applied the issue 🐛 Avoid extra DB query per menu item Needs review
- Status changed to Needs work
4 months ago 11:53am 5 September 2024 - 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Also fails because \Drupal\Core\Menu\DefaultMenuLinkTreeManipulators::checkAccess, if the menu link is not updated before BlockViewBuilder::preRender.
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
After reviewing the Drupal Issue Queue the best short-term solution is to use the patch from ✨ Allow MenuLinkTree manipulators to be altered Needs work to alter the menu link tree.
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
We will create a new branch and MR with the manipulators approximation if the issue ✨ Allow MenuLinkTree manipulators to be altered Needs work is fixed.
- Merge request !11Issue #3472291 by eduardo morales alberti: Override the menu links on the pre... → (Open) created by eduardo morales alberti
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
eduardo morales alberti → changed the visibility of the branch 3472291-override-the-menu to hidden.
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Created MR https://git.drupalcode.org/project/translatable_menu_link_uri/-/merge_re... using menu tree manipulators strategy.
- Status changed to Needs review
4 months ago 11:00am 6 September 2024 - Status changed to Postponed
about 2 months ago 6:44pm 9 November 2024 - 🇵🇱Poland jsobiecki Wroclaw
Hello Eduardo,
Thank you for your patch. Unfortunately, I need to put it on pause. The reason behind this is that you are using code that is not part of Drupal core. The fragments you are using are still in development at the moment ( https://www.drupal.org/i/3091246 → ) and needs work.
Generally, I like the approach as it axe's some old hooks, but since it's not yet part of core, I'd rather wait.
Maybe good idea would be to start release 3.x after the dependent change will be part of both 10.x and 11.x branches of Drupal. I think axing 9.x and 8.x is not a bad thing at this moment.