- Issue created by @jurgenhaas
-
jurgenhaas β
committed f9b05d94 on 3.0.x
Issue #3472261 by jurgenhaas: Cleanup PhpStan test
-
jurgenhaas β
committed f9b05d94 on 3.0.x
- Issue was unassigned.
- Status changed to Needs review
9 months ago 12:10pm 6 September 2024 - π©πͺGermany jurgenhaas Gottmadingen
PHPStan is now green as well. I've added a couple of
@todo
in the code where the clean-up identified some obviously broken functionality which I wasn't able to resolve right away. - πΊπΈUnited States erutan
This has been committed to the module already, should this just be closed along with https://www.drupal.org/project/fullcalendar/issues/3472260 π Cleanup PHPCS test Needs review ?
- Status changed to Active
10 days ago 8:22pm 4 June 2025 - πΊπΈUnited States dcam
I'm setting this issue back to active because there was a commit for it, but there's more work to do. The PhpStan (next minor) test is failing. It's allowed to fail, which is fine. But someone needs to resolve any problems with it.
- First commit to issue fork.
- Merge request !64fix: fixed phpstan in ResultController.php and UpdateController.php β (Merged) created by Unnamed author
Hi there, I have solved all the issues with phpstan and phpcs in this project expect one.
```
------ -----------------------------------------------------------------------
Line src/Plugin/fullcalendar/type/FullCalendar.php
------ -----------------------------------------------------------------------
1766 Relying on entity queries to check access by default is deprecated in
drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or
FALSE to specify whether access should be checked.
π‘ See https://www.drupal.org/node/3201242 β
------ -----------------------------------------------------------------------
```
we get the above error when `$tids = $query->execute();````
------ -----------------------------------------------------------------------
Line src/Plugin/fullcalendar/type/FullCalendar.php
------ -----------------------------------------------------------------------
1766 Call to method Drupal\Core\Entity\Query\QueryInterface::accessCheck()
with true will always evaluate to true.
πͺͺ method.alreadyNarrowedType
π‘ Because the type is coming from a PHPDoc, you can turn off this
check by setting treatPhpDocTypesAsCertain: false in your
phpstan.neon.
------ -----------------------------------------------------------------------
```
and the above when `$tids = $query->accessCheck(TRUE)->execute();`-
mandclu β
committed 2f533562 on 3.0.x authored by
techmantejas β
Issue #3472261 by techmantejas, mandclu: Cleanup PhpStan test
-
mandclu β
committed 2f533562 on 3.0.x authored by
techmantejas β
- π¨π¦Canada mandclu
Thanks for the additional work here. Great to have both phpstan tests passing.