- Issue created by @Kartagis
- 🇭🇺Hungary Gábor Hojtsy Hungary
Moving the localization server which is where the error shows up. Can you not save it or "just" an error shows up but you can still save it?
- 🇫🇷France fmb Perpinyà, Catalonia, EU
- @kartagis what module does this string come from?
- I think the whole
:API-specification-compliant
pattern should be present in the translation.
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
I was not able to replicate this issue in a local environment:
I used main branch from drupal-infrastructure gitlab repository,
I used 3.0.x-dev branch for l10n_server module.The string id i tried to translate, and had no problem is the #5052.
- 🇫🇷France fmb Perpinyà, Catalonia, EU
String 5052 (Audio File Info) does not have this issue. In string 2718592, the "JSON:API-specification-compliant" is partly interpreted as a replacement token (
:API-specification-compliant
), apparently because of the colon. If you can replicate this bug, it might be related to the regexp in the TranslateForm::validateForm() method. - 🇪🇸Spain guiu.rocafort.ferrer Barcelona
The string id i wrote in the comment #7 was wrong, i did not realise the id in my local setup is different than the one in localize.drupal.org, so İ updated the comment accordingly.
Sorry about that.
- 🇹🇷Turkey Kartagis Istanbul
Of course it has no issues Guiu, because it doesn't have a colon. I suspect all strings that have colon will have this issue.
- 🇹🇷Turkey Kartagis Istanbul
It is most interesting Guiu, you had no problem with the Spanish translation and yet I had problem with the Turkish translation.
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
guiu.rocafort.ferrer → changed the visibility of the branch 3472254-wrongly-parsed-sentence to hidden.
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
We found out that the code was treating JSON:XXXXXX as a variable, this is a general problem where it is interpreting JSON:API as a variable name, when it is actually the drupal core submodule name.
I added an exception to the regular expression checking the variables, that would ignore any value starting with "JSON:" from being interpreted as a variable.
- Merge request !65Issue #3472254 by guiu.rocafort.ferrer, kartagis, fmb, gábor hojtsy: Broaden... → (Merged) created by guiu.rocafort.ferrer
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
@fmb I have checked that in the frontend the variables are not incorrectly hightlighted by the javascript code.
- 🇫🇷France fmb Perpinyà, Catalonia, EU
Thanks Guiu! This now needs to be backported to 7.x-1.x-dev.
-
fmb →
committed a360a10b on 3.0.x authored by
guiu.rocafort.ferrer →
Issue #3472254 by guiu.rocafort.ferrer, kartagis, fmb, gábor hojtsy:...
-
fmb →
committed a360a10b on 3.0.x authored by
guiu.rocafort.ferrer →
- 🇹🇷Turkey Kartagis Istanbul
When will this take effect? Because I'm still getting the exact same error, leaving me unable to save. Maybe that string has to be re-exported?
- 🇫🇷France fmb Perpinyà, Catalonia, EU
@kartagis for now, the fix was applied to the 3.0.x branch of the l10n_server module, which is currently under development. The next step is to backport it to the older 7.x-1.x branch, which is still the live version (i.e. the on on localize.drupal.org).
It is a good thing that
JSON:API
does not match, it means it will not be mistaken as a replacement token. - Merge request !66Issue #3472254 by guiu.rocafort.ferrer, fmb, kartagis, gábor hojtsy: Wrongly parsed sentence → (Merged) created by guiu.rocafort.ferrer
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
I have applied the changes in a new merge request to 7.x-1.x (3472254-wrongly-parsed-sentence-7.x).
-
guiu.rocafort.ferrer →
committed b5a8a5e3 on 7.x-1.x
Issue #3472254 by guiu.rocafort.ferrer, fmb, kartagis, gábor hojtsy:...
-
guiu.rocafort.ferrer →
committed b5a8a5e3 on 7.x-1.x
- 🇫🇷France fmb Perpinyà, Catalonia, EU
Thanks Guiu! I successfully tested this on a development Drupal 7 instance. Failing tests are not related to this change. @drumm, could you deploy this onto the live instance (localize.drupal.org)?
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 2 months ago 7:30am 2 January 2025 - 🇹🇷Turkey Kartagis Istanbul
I don't know if I should file a new ticket because I'm getting a similar error, so... This time the error is
Missing variable(s): @extension
and this is the string. - 🇫🇷France fmb Perpinyà, Catalonia, EU
What is the translation you are trying to save?