Remove Metadata subfields

This is a great suggestion. I introduced the metadata field early on when I started the port to GraphQL 4 because I was concerned about potential key collisions. But indeed this is making the migration from GraphQL 3 to GraphQL 4 more difficult than strictly needed.

I will have a look if this can be easily reverted to the original layout as used previously.

If we change this back this will be a B/C break but I think this is OK since we are still in early alpha.

I added an MR that moves the metadata fields in the root. There were 2 collisions:

1. WebformElementMetadata.required is conflicting with WebformElement.required. This has been solved by keeping the WebformElement.required field and its corresponding type WebformRequiredElement. The fields WebformElementMetadata.required and WebformElementMetadata.requiredError are removed. This best aligns with the how it was done previously in the 8.x-1.x branch.
2. WebformElementMetadata.multiple is conflicting with WebformElement.multiple. This has been solved by renaming WebformElement.multiple to WebformElement.multipleValues so that it matches the type name WebformElementMultipleValuesBase.

LGTM :)

Thanks for testing! Merged in 2.x.

Automatically closed - issue fixed for 2 weeks with no activity.