Remove Simple Sitemap because it breaks the installer in a WebAssembly runtime

Created on 4 September 2024, 3 months ago
Updated 19 September 2024, 2 months ago

Problem/Motivation

The Starshot prototype included Simple Sitemap, which breaks the interactive installer in a WebAssembly runtime due to the (current) lack of XmlWriter support.

Since it's not yet clear if Simple Sitemap will be part of the final Drupal CMS product, I think the path of least resistance here is to remove Simple Sitemap from the code base, thus unblocking further work on the trial experience, and restoring it when needed (most likely by the SEO track).

πŸ“Œ Task
Status

Fixed

Component

Track: Trial Experience

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !59Remove Simple Sitemap β†’ (Merged) created by phenaproxima
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Status changed to Needs review 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mglaman WI, USA

    It kind of feels wrong to remove solely because of the trial runtime when this is a valuable module. It seems more appropriate to call it out needs a better owner recipe

  • Pipeline finished with Failed
    3 months ago
    Total: 246s
    #273904
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    In the SEO tracks WIP MR, I am removing it from the core recipes and adding it in the Advanced SEO recipe that will be optionally installed in the installer/project browser.

    Does that help?

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Actually, not true yet. I haven't removed items from the base recipe, but will most likely need to.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    It kind of feels wrong to remove solely because of the trial runtime when this is a valuable module.

    Nobody's disputing that it's a valuable module, but we're not yet clear on whether it should be installed by default in the "base recipe" (as @thejimbirch mentioned), or as part of some more full-featured SEO-specific recipe. That's for the SEO track leads to decide.

    In the meantime, the presence of this module is actively preventing progress on the trial experience, so I think removing it is completely fine.

  • πŸ‡ΊπŸ‡ΈUnited States mglaman WI, USA

    Okay, works for me! I wanted to avoid any perception of minimizing Drupal CMS due to WebAssembly by folks

  • Pipeline finished with Canceled
    3 months ago
    Total: 476s
    #273965
  • Pipeline finished with Success
    3 months ago
    Total: 337s
    #273980
  • Status changed to RTBC 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Skipped
    3 months ago
    #273987
  • Pipeline finished with Skipped
    3 months ago
    #273990
  • Status changed to Fixed 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡©πŸ‡ͺGermany gbyte Berlin

    Hey, creator of simple_sitemap here. I'm happy to work with you on a solution (like finding a replacement for xmlWriter) in case you are interested in keeping this module in the code base - let me know.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Hey @gbyte - I just want to be clear that nothing about this issue is meant to be a ding on Simple Sitemap itself. I believe its removal from the code base is likely temporary, which seems to have been confirmed by Jim in #6.

    This is really more of a process issue, honestly; Simple Sitemap should be restored by the SEO track in one of their recipes. Since they haven't yet submitted an advanced SEO recipe, Simple Sitemap's presence was just a holdover from the prototype, so it made sense to remove it for now. If you want to explicitly encourage the SEO track to include Simple Sitemap (but it doesn't seem like you need to ;), I would suggest doing that in #3470830: Create an advanced SEO Recipe β†’ .

    Changing to SimpleXML might well be a reasonable idea for broader compatibility with more PHP installations, but eh...the Wasm runtime should probably support XmlWriter anyway, and that's up to @mglaman to figure out, but he's got other short-term priorities with regard to getting the trial working in time for DrupalCon Barcelona.

    So, long story short - sit tight! Although I can't speak definitely for the SEO track leads, it looks like Drupal CMS very much wants to include Simple Sitemap, just at a slightly different "angle".

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    Confirmed. If you look at MR 47 on the issue linked in #14 you can see the module is included. Thanks for working with us on the config validation issue!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024